Test live: https://calypso.live/?branch=add/error-message-for-no-domain

when starting the flow with a bad domain name, display an error message and redirect to the main flow

How about returning to the begining of the flow instead? Letting users choose a different domain, rather then defaulting them to the site flow.

I'm also not sure a visible notice is needed here. Unless we know how users ended up with a bad domain query in the first place, the notice is not going to be very useful.

The problem with keeping them in the domain-first flow is that there is no domain step in that flow, and adding one is problematic.

This solution looks fine to me. I propose we just go with whatever is simplest, since this is an edge case.

Code 👍
Not sure about the error message (what does it mean later for the user?).

Product 👍

Howdy! Editor at your disposal :)

Question: What does "bad" domain name mean here? Unavailable? Too short? Includes unacceptable characters? Something else? Is "This domain is unavailable" too vague here?

""X" isn't available as a domain. Keep going with setup -- you'll be able to choose another domain later."

I propose we just go with whatever is simplest, since this is an edge case.

I don't think displaying a notice is the simplest solution here. I agree with @ranh that

Unless we know how users ended up with a bad domain query in the first place, the notice is not going to be very useful.

and that we should simply hard redirect the user to /domains once that route is available.

Thanks for the notes @michelleweber! I think we're going to remove this notice altogether though :) So clearing the copy review label.

Product 👍

Though I think we should test this again once we have the landing page at /domains. I'll add a note to #1425-tr.

Code 👍